Thanks a lot for review, Mads. Running through tests and submitting.
http://codereview.chromium.org/1265003/diff/1/2 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/1265003/diff/1/2#newcode1317 src/ia32/stub-cache-ia32.cc:1317: __ mov(ecx, Operand(esp, argc * kPointerSize)); On 2010/03/25 09:56:28, Mads Ager wrote:
Could you add a comment here:
// Push the element.
Done. http://codereview.chromium.org/1265003/diff/1/2#newcode1321 src/ia32/stub-cache-ia32.cc:1321: Immediate(Factory::the_hole_value())); On 2010/03/25 09:56:28, Mads Ager wrote:
This looks like the right thing in any case. I remember commenting
that this
should probably be the_hole on the first review. ;)
I am sorry, Mads. http://codereview.chromium.org/1265003 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
