Reviewers: Mads Ager, Erik Corry, Description: Avoid having a LIBS setting when compiling the V8 library because this interferes with the shared library build. Only prepend the v8 to the LIBS list when building samples, d8, or cctest.
Please review this at http://codereview.chromium.org/1387004 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M SConstruct Index: SConstruct =================================================================== --- SConstruct (revision 4288) +++ SConstruct (working copy) @@ -1009,7 +1009,6 @@ # Link the object files into a library. env.Replace(**context.flags['v8']) - env.Prepend(LIBS=[library_name]) context.ApplyEnvOverrides(env) if context.options['library'] == 'static': @@ -1044,7 +1043,9 @@ sample_env.Depends(sample_program, library) context.sample_targets.append(sample_program) - cctest_program = env.SConscript( + cctest_env = env.Clone() + cctest_env.Prepend(LIBS=[library_name]) + cctest_program = cctest_env.SConscript( join('test', 'cctest', 'SConscript'), build_dir=join('obj', 'test', target_id), exports='context object_files', -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
