LGTM. We could do the same for the strange array-with-two-extra-properties that is returned by RegExp.prototype.exec.
http://codereview.chromium.org/1350003/diff/1/2 File src/bootstrapper.cc (right): http://codereview.chromium.org/1350003/diff/1/2#newcode765 src/bootstrapper.cc:765: 3); You already made a constant for this '3'. http://codereview.chromium.org/1350003/diff/1/3 File src/factory.h (right): http://codereview.chromium.org/1350003/diff/1/3#newcode44 src/factory.h:44: Inadvertent edit? http://codereview.chromium.org/1350003/diff/1/7 File src/runtime.cc (right): http://codereview.chromium.org/1350003/diff/1/7#newcode1263 src/runtime.cc:1263: // Map has changed, so use generic, but slower, method. This is a strange situation. Do we have a test of this? Does JSC set the same attributes on the properties in this case. http://codereview.chromium.org/1350003 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
