Thanks!
-- Vitaly http://codereview.chromium.org/1444001/diff/1/3 File src/objects-inl.h (right): http://codereview.chromium.org/1444001/diff/1/3#newcode261 src/objects-inl.h:261: for (int i = 0, len = length(); i < len; i++) { On 2010/03/26 18:54:35, antonm wrote:
maybe prefetch length() not to call virtual method in the loop?
Huh? http://codereview.chromium.org/1444001/diff/1/4 File src/objects.cc (right): http://codereview.chromium.org/1444001/diff/1/4#newcode4668 src/objects.cc:4668: for (i = 0; hasher.is_array_index() && i < length; i++) { On 2010/03/26 18:54:35, antonm wrote:
would you mind putting i < length into parenthesis? I am always
uneasy figuring
out priorities :)
Done. http://codereview.chromium.org/1444001/diff/1/4#newcode4687 src/objects.cc:4687: if (StringShape(this).IsSequentialAscii()) { On 2010/03/26 18:54:35, antonm wrote:
what's the benefit of doing StringShape(this) several times? Maybe
only once or
use ->IsAscii... (or there are some missing checks?)
There's no other function on String to test for sequential ascii/two-byte shapes. IsSeqAsciiString and IsSeqTwoByteString are functions on Object that also tests whether an object is a String. http://codereview.chromium.org/1444001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
