http://codereview.chromium.org/1367004/diff/1/3
File src/conversions.cc (right):
http://codereview.chromium.org/1367004/diff/1/3#newcode458
src/conversions.cc:458: ++current;
On 2010/03/29 10:43:10, Erik Corry wrote:
This is changing the implementation for strings that end in '.'. Do
we have
good test coverage for that?
We do. For instance:
str-to-num.js:91:
assertEquals(5, toNumber("5."));
assertEquals(5, toNumber("+5."));
assertEquals(-5, toNumber("-5."));
http://codereview.chromium.org/1367004/diff/1/3#newcode587
src/conversions.cc:587: // fractional part it could be parsed fatser
(without check for
On 2010/03/29 10:43:10, Erik Corry wrote:
fatser -> faster
check -> checks
Done.
http://codereview.chromium.org/1367004/diff/1/3#newcode588
src/conversions.cc:588: // spaces, overflow, etc).
On 2010/03/29 10:43:10, Erik Corry wrote:
etc -> etc.
Done.
http://codereview.chromium.org/1367004
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
