LSTM (Look sane to me).
You might want to consider wrapping the #includes also inside the #ifdefs
for
ENABLE_CPP_PROFILES_PROCESSOR. It might cut down compile time a small bit.
http://codereview.chromium.org/1514006/diff/1/2
File SConstruct (right):
http://codereview.chromium.org/1514006/diff/1/2#newcode1
SConstruct:1: # Copyright 2008 the V8 project authors. All rights
reserved.
2010.
http://codereview.chromium.org/1514006/diff/1/4
File src/cpu-profiler-inl.h (right):
http://codereview.chromium.org/1514006/diff/1/4#newcode39
src/cpu-profiler-inl.h:39: #ifdef ENABLE_CPP_PROFILES_PROCESSOR
You could wrap the entire contents of the file except the license
comment.
http://codereview.chromium.org/1514006
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
