I committed this to bleeding_edge as r4334. I'll push it out to trunk. On Thu, Apr 1, 2010 at 12:08 AM, Kevin Millikin <[email protected]>wrote:
> LGTM. > > > On Wed, Mar 31, 2010 at 3:15 PM, <[email protected]> wrote: > >> Reviewers: Kevin Millikin, >> >> Message: >> Kevin, may you have a look? >> >> Description: >> Make check for writes without remembered set updates less restrictive. >> >> One doesn't have to update remembered set if it already contains a mark >> for >> the given address. >> >> BUG=39766 >> >> Please review this at http://codereview.chromium.org/1603002 >> >> Affected files: >> M src/objects-inl.h >> >> >> Index: src/objects-inl.h >> diff --git a/src/objects-inl.h b/src/objects-inl.h >> index >> 6d7bad751210ef2855ea8031c5f197684077f074..d363d4d6ab29847abca988e340afc65862e9eff2 >> 100644 >> --- a/src/objects-inl.h >> +++ b/src/objects-inl.h >> @@ -742,7 +742,8 @@ Object* Object::GetProperty(String* key, >> PropertyAttributes* attributes) { >> } else { \ >> ASSERT(mode == SKIP_WRITE_BARRIER); \ >> ASSERT(Heap::InNewSpace(object) || \ >> - !Heap::InNewSpace(READ_FIELD(object, offset))); \ >> + !Heap::InNewSpace(READ_FIELD(object, offset)) || \ >> + Page::IsRSetSet(object->address(), offset)); \ >> } >> >> #define READ_DOUBLE_FIELD(p, offset) \ >> >> >> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
