Reviewers: floitschv8_gmail.com,
Message:
We discussed it in email conversation but I forgot to include it that time.
Description:
Updating a comment in InternalStringToInt.
Please review this at http://codereview.chromium.org/1547017
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/conversions.cc
Index: src/conversions.cc
===================================================================
--- src/conversions.cc (revision 4338)
+++ src/conversions.cc (working copy)
@@ -357,9 +357,10 @@
return sign ? -gay_strtod(buffer, NULL) : gay_strtod(buffer, NULL);
}
- // TODO(serya): The following legacy code causes accumulating rounding
- // error for number greater than ~2^56. It should be rewritten using long
- // arithmetic.
+ // The following code causes accumulating rounding error for numbers
greater
+ // than ~2^56. It's explicitly allowed in the spec: "if R is not 2, 4,
8, 10,
+ // 16, or 32, then mathInt may be an implementation-dependent
approximation to
+ // the mathematical integer value" (15.1.2.2).
int lim_0 = '0' + (radix < 10 ? radix : 10);
int lim_a = 'a' + (radix - 10);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
