http://codereview.chromium.org/1549016/diff/12001/8002 File src/builtins.cc (right):
http://codereview.chromium.org/1549016/diff/12001/8002#newcode728 src/builtins.cc:728: (2 * actual_delete_count >= len + item_count)) { looks like you're trying to keep the number of writes minimal. In this case for inplace result number of writes is actual_start + tail_length (+ tail_length to fill with the holes) while out of place result requires item_count + tail_length moves. Thus condition might be actual_start + tail_length >= item_count. http://codereview.chromium.org/1549016/diff/12001/8002#newcode759 src/builtins.cc:759: elms = LeftTrimFixedArray(elms, actual_start); good you noticed that---was going to bring your attention to it :) http://codereview.chromium.org/1549016 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
