http://codereview.chromium.org/1628003/diff/1/4 File src/arm/ic-arm.cc (right):
http://codereview.chromium.org/1628003/diff/1/4#newcode728 src/arm/ic-arm.cc:728: __ push(r1); // receiver On 2010/04/06 12:04:28, Vitaly wrote:
Use stm here?
Done. http://codereview.chromium.org/1628003/diff/1/2 File test/mjsunit/string-index.js (right): http://codereview.chromium.org/1628003/diff/1/2#newcode170 test/mjsunit/string-index.js:170: // Test for keyed ic. On 2010/04/06 12:04:28, Vitaly wrote:
Please also cover the case when the receiver becomes smi.
Done. http://codereview.chromium.org/1628003/diff/1/2#newcode178 test/mjsunit/string-index.js:178: assertEquals(new Number(foo[1]) + 1, result); On 2010/04/06 12:04:28, Vitaly wrote:
Why "+ 1"?
Done. http://codereview.chromium.org/1628003/diff/1/2#newcode188 test/mjsunit/string-index.js:188: assertEquals(new Number(foo[key]) + 1, result); On 2010/04/06 12:04:28, Vitaly wrote:
Same here.
Done. http://codereview.chromium.org/1628003 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
