LGTM
http://codereview.chromium.org/1547023/diff/1/2 File include/v8-profiler.h (right): http://codereview.chromium.org/1547023/diff/1/2#newcode159 include/v8-profiler.h:159: static void StartProfiling(Handle<String> title = Handle<String>()); Should this function maybe mandate passing a title? http://codereview.chromium.org/1547023/diff/1/4 File src/cpu-profiler.cc (right): http://codereview.chromium.org/1547023/diff/1/4#newcode373 src/cpu-profiler.cc:373: "RegExp: ", Do we need to pass the "RegExp: " prefix when the event is already RegExp specific? http://codereview.chromium.org/1547023/diff/1/9 File src/profile-generator.cc (right): http://codereview.chromium.org/1547023/diff/1/9#newcode511 src/profile-generator.cc:511: *entry++ = FLAG_prof_browser_mode ? program_entry_ : NULL; Please make a comment here about how browser mode differs. http://codereview.chromium.org/1547023 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
