http://codereview.chromium.org/1456001/diff/4001/5001 File src/liveedit.cc (right):
http://codereview.chromium.org/1456001/diff/4001/5001#newcode450 src/liveedit.cc:450: static bool IsStubCode(Code* code) { On 2010/04/07 07:06:05, Søren Gjesse wrote:
I will suggest making a IsJSFunctionCode which checks == with
Code::FUNCTION
instead. The term "stub" is a bit overloaded.
Done. http://codereview.chromium.org/1456001/diff/4001/5001#newcode465 src/liveedit.cc:465: if (!IsStubCode(shared_info->code())) { On 2010/04/07 07:06:05, Søren Gjesse wrote:
Maybe (shared->code()->kind() == Code::FUNCTION) is just as good here?
I am not sure I won't need more checks later. I also use this function in other place, so I'd rather not inline it. http://codereview.chromium.org/1456001/diff/4001/5001#newcode472 src/liveedit.cc:472: Handle<Code> new_original_code = Factory::CopyCode(compile_info_wrapper.GetFunctionCode()); On 2010/04/07 07:06:05, Søren Gjesse wrote:
Long line, please make sure it lints.
Sorry about this. Done http://codereview.chromium.org/1456001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
