I am for removing the "ndef" and "def" on the #else/#endif comments, as I
find
it confusing. Just having the name of the variable will make the reader
look at
the actual #ifdef/#ifndef/#else.
http://codereview.chromium.org/1605017/diff/1/26
File src/arm/regexp-macro-assembler-arm.h (right):
http://codereview.chromium.org/1605017/diff/1/26#newcode42
src/arm/regexp-macro-assembler-arm.h:42: #else // ndef
V8_INTERPRETED_REGEXP
Is this "ndef" is not something we normally put in?
http://codereview.chromium.org/1605017/diff/1/26#newcode277
src/arm/regexp-macro-assembler-arm.h:277: #endif // ndef
V8_INTERPRETED_REGEXP
If we do should it be at the #endif as well?
http://codereview.chromium.org/1605017/diff/1/28
File src/jsregexp.cc (right):
http://codereview.chromium.org/1605017/diff/1/28#newcode240
src/jsregexp.cc:240: #else // ! V8_INTERPRETED_REGEXP (RegExp native
code)
No space after !
http://codereview.chromium.org/1605017/diff/1/28#newcode368
src/jsregexp.cc:368: #endif // !V8_INTERPRETED_REGEXP
Should the "endif comment have the !?
http://codereview.chromium.org/1605017/diff/1/8
File tools/gyp/v8.gyp (right):
http://codereview.chromium.org/1605017/diff/1/8#newcode34
tools/gyp/v8.gyp:34: 'v8_regexp%': 'native',
This variable (v8_regeexp) should either be removed (as it is currently
never tested) or a condition should be added below to define
V8_INTERPRETED_REGEXP.
http://codereview.chromium.org/1605017/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
