http://codereview.chromium.org/1576026/diff/1/5 File src/arm/disasm-arm.cc (right):
http://codereview.chromium.org/1576026/diff/1/5#newcode661 src/arm/disasm-arm.cc:661: } else if ((type == 0) && instr->IsMiscType0()) { On 2010/04/08 12:56:30, Erik Corry wrote:
This is a little strange to me, but if it matches the manual
organization then
I'm fine with it.
Section A5.2 in ARM® Architecture Reference Manual ARM®v7-A and ARM®v7-R edition. http://codereview.chromium.org/1576026/diff/1/5#newcode735 src/arm/disasm-arm.cc:735: Unknown(instr); // not used by V8 On 2010/04/08 12:56:30, Erik Corry wrote:
UNREACHABLE(); // Handled by IsMiscType0 code above.
Done. http://codereview.chromium.org/1576026/diff/1/5#newcode751 src/arm/disasm-arm.cc:751: Unknown(instr); // not used by V8 On 2010/04/08 12:56:30, Erik Corry wrote:
And here.
Done. http://codereview.chromium.org/1576026/diff/1/4 File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/1576026/diff/1/4#newcode1629 src/arm/simulator-arm.cc:1629: UNIMPLEMENTED(); On 2010/04/08 12:56:30, Erik Corry wrote:
UNREACHABLE
Done. http://codereview.chromium.org/1576026/diff/1/4#newcode1657 src/arm/simulator-arm.cc:1657: UNIMPLEMENTED(); On 2010/04/08 12:56:30, Erik Corry wrote:
&here
Done. http://codereview.chromium.org/1576026/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
