On 2010/04/08 11:23:41, antonm wrote:
Thanks a lot, Ryan.
LGTM and I going to land it, but there are some small amendments I could
do on
landing.
Thanks!
http://codereview.chromium.org/1594017/diff/5002/14003
File test/cctest/test-strings.cc (right):
http://codereview.chromium.org/1594017/diff/5002/14003#newcode360
test/cctest/test-strings.cc:360: CHECK_EQ(false, str->IsFlat());
would you mind if I change that to CHECK(!str->IsFlat())?
http://codereview.chromium.org/1594017/diff/5002/14003#newcode364
test/cctest/test-strings.cc:364: CHECK_EQ(true, str->IsFlat());
would you mind if I change that to CHECK(str->IsFlat())?
That's fine
http://codereview.chromium.org/1594017/diff/5002/14003#newcode369
test/cctest/test-strings.cc:369: for (int j = 0; j < 10; j++) {
why j, not i? :) I could change to i when landing or could keep your j,
up to
you.
Oh, I just changed that when I discovered the i:: internal namespace alias.
It
can be changed back.
http://codereview.chromium.org/1594017/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
