Too late-comments :(

http://codereview.chromium.org/1556019/diff/14001/15001
File src/regexp.js (right):

http://codereview.chromium.org/1556019/diff/14001/15001#newcode170
src/regexp.js:170: cache.answerSaved = false;
No need to set answerSaved here. Set it, unconditionally, to saveAnswer
when updating the cache values below.

Due to the call to ToString below, we can't trust the value set here to
stick anyway.

http://codereview.chromium.org/1556019/diff/14001/15001#newcode241
src/regexp.js:241: cache.answerSaved = true;
I.e., always set answerSaved to saveAnswer here.

http://codereview.chromium.org/1556019/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

To unsubscribe, reply using "remove me" as the subject.

Reply via email to