LGTM
Will the end goal to totally remove the need for
ENABLE_CPP_PROFILES_PROCESSOR?
http://codereview.chromium.org/1635005/diff/2001/3002
File src/cpu-profiler-inl.h (right):
http://codereview.chromium.org/1635005/diff/2001/3002#newcode64
src/cpu-profiler-inl.h:64: result->filler = 1; // !=
SamplingCircularQueue::kClear.
Please add
ASSERT(result->filler = != SamplingCircularQueue::kClear);
http://codereview.chromium.org/1635005/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.