LGTM.
Before submitting please double-check we have all interesting cases covered
by
our tests.
-- Vitaly
http://codereview.chromium.org/1558040/diff/1/2
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1558040/diff/1/2#newcode11060
src/ia32/codegen-ia32.cc:11060: static int
NanComparisionResult(Condition cc) {
nit: In other places (constant name) it's NaN.
http://codereview.chromium.org/1558040/diff/1/2#newcode11075
src/ia32/codegen-ia32.cc:11075: // for Nan and undefined.
nit: NaN.
http://codereview.chromium.org/1558040/diff/1/2#newcode11082
src/ia32/codegen-ia32.cc:11082: // Check for undefined.
It might help to have a short summary of undefined comparison rules
here:
undefined == undefined, but not undefined <= undefined, etc.
http://codereview.chromium.org/1558040/diff/1/2#newcode11095
src/ia32/codegen-ia32.cc:11095: __ Set(eax, Immediate(0));
Use Smi::FromInt(EQUAL) instead of 0.
http://codereview.chromium.org/1558040/diff/1/2#newcode11102
src/ia32/codegen-ia32.cc:11102: Immediate(Factory::heap_number_map()));
nit: Indent.
http://codereview.chromium.org/1558040/diff/1/2#newcode11127
src/ia32/codegen-ia32.cc:11127: __ setcc(above_equal, eax);
ASSERT(1 != EQUAL).
http://codereview.chromium.org/1558040/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
