Revision: 4408
Author: [email protected]
Date: Wed Apr 14 01:54:08 2010
Log: Create const ints for int8_t and int32_t in jmp assembler (making win64 build happy)
Review URL: http://codereview.chromium.org/1637009
http://code.google.com/p/v8/source/detail?r=4408

Modified:
 /branches/bleeding_edge/src/x64/assembler-x64.cc

=======================================
--- /branches/bleeding_edge/src/x64/assembler-x64.cc Mon Apr 12 03:07:50 2010 +++ /branches/bleeding_edge/src/x64/assembler-x64.cc Wed Apr 14 01:54:08 2010
@@ -1139,22 +1139,24 @@
   EnsureSpace ensure_space(this);
   last_pc_ = pc_;
   if (L->is_bound()) {
+    const int short_size = sizeof(int8_t);
+    const int long_size = sizeof(int32_t);
     int offs = L->pos() - pc_offset() - 1;
     ASSERT(offs <= 0);
-    if (is_int8(offs - sizeof(int8_t))) {
+    if (is_int8(offs - short_size)) {
       // 1110 1011 #8-bit disp.
       emit(0xEB);
-      emit((offs - sizeof(int8_t)) & 0xFF);
+      emit((offs - short_size) & 0xFF);
     } else {
       // 1110 1001 #32-bit disp.
       emit(0xE9);
-      emitl(offs - sizeof(int32_t));
+      emitl(offs - long_size);
     }
   } else  if (L->is_linked()) {
     // 1110 1001 #32-bit disp.
     emit(0xE9);
     emitl(L->pos());
-    L->link_to(pc_offset() - sizeof(int32_t));
+    L->link_to(pc_offset() - long_size);
   } else {
     // 1110 1001 #32-bit disp.
     ASSERT(L->is_unused());

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to