Reviewers: Søren Gjesse,
Description:
Only put VM state entry if a symbolized stacktrace is empty.
This makes more sense than putting "(program)" as the root of
every stack trace in broswer mode.
Please review this at http://codereview.chromium.org/1631018/show
Affected files:
M src/profile-generator.cc
Index: src/profile-generator.cc
diff --git a/src/profile-generator.cc b/src/profile-generator.cc
index
a842eb2fef5bef6b9ae61e3f12217fd6a4db0ac8..c02f7fb0dcbad06ccecca5d3f355dcacbe7581dc
100644
--- a/src/profile-generator.cc
+++ b/src/profile-generator.cc
@@ -562,8 +562,12 @@ void ProfileGenerator::RecordTickSample(const
TickSample& sample) {
}
if (FLAG_prof_browser_mode) {
- // Put VM state as the topmost entry.
+ // If no frames were symbolized, the VM state entry in.
+ for (CodeEntry** e = entries.start(); e != entry; ++e) {
+ if (*e != NULL) goto skip;
+ }
*entry++ = EntryForVMState(sample.state);
+skip: ;
}
profiles_->AddPathToCurrentProfiles(entries);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
