Revision: 4430
Author: [email protected]
Date: Thu Apr 15 07:12:17 2010
Log: Only put VM state entry if a symbolized stacktrace is empty.
This makes more sense than putting "(program)" as the root of
every stack trace in broswer mode.
Review URL: http://codereview.chromium.org/1631018
http://code.google.com/p/v8/source/detail?r=4430
Modified:
/branches/bleeding_edge/src/profile-generator.cc
=======================================
--- /branches/bleeding_edge/src/profile-generator.cc Thu Apr 15 04:37:29
2010
+++ /branches/bleeding_edge/src/profile-generator.cc Thu Apr 15 07:12:17
2010
@@ -562,8 +562,17 @@
}
if (FLAG_prof_browser_mode) {
- // Put VM state as the topmost entry.
- *entry++ = EntryForVMState(sample.state);
+ bool no_symbolized_entries = true;
+ for (CodeEntry** e = entries.start(); e != entry; ++e) {
+ if (*e != NULL) {
+ no_symbolized_entries = false;
+ break;
+ }
+ }
+ // If no frames were symbolized, put the VM state entry in.
+ if (no_symbolized_entries) {
+ *entry++ = EntryForVMState(sample.state);
+ }
}
profiles_->AddPathToCurrentProfiles(entries);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
