http://codereview.chromium.org/1539039/diff/4001/5003 File src/ia32/codegen-ia32.h (right):
http://codereview.chromium.org/1539039/diff/4001/5003#newcode891 src/ia32/codegen-ia32.h:891: // overhead. Copying of overlapping regions is not supported. Drive by comment, If we will be using these code generation methods from other places than classes inheriting from StringStubBase then I suggest getting rid of the StringStubBase class and move the functions to a StringHelper class inside codegen-ia32.cc (like the FloatingPointHelper class). http://codereview.chromium.org/1539039/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
