The problem was: although singleton was in place, it lacked profiles generator instance, which I started to use in my infamous change. Testing for "is_profiling" checks both singleton instance and generator object presence.
Interesting enough that it was really hard to see that I have a crash just by running test_shell. I could write a small post-mortem on this topic. On Fri, Apr 16, 2010 at 18:08, <[email protected]> wrote: > LGTM (Since I guess the singleton would actually not be null if the setup > method > has been called). > > http://codereview.chromium.org/1630027/show > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
