Reviewers: Erik Corry, Description: Update comment to provide the correct usage of the Disassembler class.
[email protected] Please review this at http://codereview.chromium.org/1755001/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/disasm-arm.cc Index: src/arm/disasm-arm.cc =================================================================== --- src/arm/disasm-arm.cc (revision 4452) +++ src/arm/disasm-arm.cc (working copy) @@ -34,10 +34,9 @@ // NameConverter converter; // Disassembler d(converter); // for (byte* pc = begin; pc < end;) { -// char buffer[128]; -// buffer[0] = '\0'; +// v8::internal::EmbeddedVector<char, 256> buffer; // byte* prev_pc = pc; -// pc += d.InstructionDecode(buffer, sizeof buffer, pc); +// pc += d.InstructionDecode(buffer, pc); // printf("%p %08x %s\n", // prev_pc, *reinterpret_cast<int32_t*>(prev_pc), buffer); // } -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
