http://codereview.chromium.org/1673006/diff/15001/7002 File src/arm/assembler-arm.h (right):
http://codereview.chromium.org/1673006/diff/15001/7002#newcode929 src/arm/assembler-arm.h:929: class ScopedConstPoolBlocker { On 2010/04/21 09:28:50, Mads Ager wrote:
I think we usually call these classes something ending in Scope: NoHandleAllocationScope, HandleScope, ZoneScope. Let's call this BlockConstPoolScope?
Done. http://codereview.chromium.org/1673006/diff/15001/7002#newcode1039 src/arm/assembler-arm.h:1039: int no_const_pool_before_; // Block emission before this pc offset. On 2010/04/21 09:28:50, Mads Ager wrote:
Can we get rid of this one or is it still used?
Not at the moment. It is still used internally in the assembler to control the const pool scope blocking cross methods of the assembler. However it's use is not exposed outside the assembler. http://codereview.chromium.org/1673006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
