Thanks a lot for spotting this and sorry for introducing the trouble.
Almost LGTM.
Am I missing something or src/bootstrapper.cc should be update as well to
build
caches per context?
http://codereview.chromium.org/1731002/diff/1/2
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/1731002/diff/1/2#newcode4179
src/arm/codegen-arm.cc:4179: __ ldr(r1, MemOperand(cp,
Context::SlotOffset(Context::GLOBAL_INDEX)));
there is CodeGenerator::ContextOperand that might be convenient here.
http://codereview.chromium.org/1731002/diff/1/2#newcode4182
src/arm/codegen-arm.cc:4182: Context::JSFUNCTION_RESULT_CACHES_INDEX)));
ditto. Plus I'd rather indent is with C in Context at same column as r
in r1
http://codereview.chromium.org/1731002/diff/1/3
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1731002/diff/1/3#newcode6561
src/ia32/codegen-ia32.cc:6561: __ mov(cache.reg(), Operand(esi,
Context::SlotOffset(Context::GLOBAL_INDEX)));
ditto for ContextOperand
http://codereview.chromium.org/1731002/diff/1/3#newcode6571
src/ia32/codegen-ia32.cc:6571: ASSERT(tmp.is_valid());
just curious. tmp.reg() below has this assert as well. What is our
common approach, to put such assert or not?
http://codereview.chromium.org/1731002/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
