http://codereview.chromium.org/1672006/diff/9001/10001 File src/liveedit-debugger.js (right):
http://codereview.chromium.org/1672006/diff/9001/10001#newcode50 src/liveedit-debugger.js:50: // This API is a legacy and is obsolete. On 2010/04/21 13:41:53, Søren Gjesse wrote:
Why not remove it then?
I will do it soon. It is still used in several places. http://codereview.chromium.org/1672006/diff/9001/10001#newcode541 src/liveedit-debugger.js:541: info_node.new_end_pos = chunk_it.TranslatePos(info_node.info.end_position); On 2010/04/21 13:41:53, Søren Gjesse wrote:
Long line.
Done. http://codereview.chromium.org/1672006/diff/9001/10005 File test/mjsunit/debug-liveedit-newsource.js (right): http://codereview.chromium.org/1672006/diff/9001/10005#newcode64 test/mjsunit/debug-liveedit-newsource.js:64: assertEquals(25, something1); On 2010/04/21 13:41:53, Søren Gjesse wrote:
Maybe add a comment to why this is not 26.
Done. http://codereview.chromium.org/1672006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
