LGTM

I hope we have good test coverage of apply with arguments.


http://codereview.chromium.org/1738003/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1738003/diff/1/2#newcode1630
src/arm/codegen-arm.cc:1630: __ bind(&loop);
How copying the arguments by having one register pointing at the source
and using post increment to avoid recalculating for each iteration?

http://codereview.chromium.org/1738003/diff/1/2#newcode1644
src/arm/codegen-arm.cc:1644: // unchanged, with 3 elements, so it is
correct when we compile the
Scary stuff "cheating" the virtual frame...

http://codereview.chromium.org/1738003/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to