http://codereview.chromium.org/1731002/diff/1/2 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/1731002/diff/1/2#newcode4179 src/arm/codegen-arm.cc:4179: __ ldr(r1, MemOperand(cp, Context::SlotOffset(Context::GLOBAL_INDEX))); On 2010/04/21 11:13:27, antonm wrote:
there is CodeGenerator::ContextOperand that might be convenient here.
Done. http://codereview.chromium.org/1731002/diff/1/2#newcode4182 src/arm/codegen-arm.cc:4182: Context::JSFUNCTION_RESULT_CACHES_INDEX))); On 2010/04/21 11:13:27, antonm wrote:
ditto. Plus I'd rather indent is with C in Context at same column as
r in r1 Done. http://codereview.chromium.org/1731002/diff/1/3 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1731002/diff/1/3#newcode6561 src/ia32/codegen-ia32.cc:6561: __ mov(cache.reg(), Operand(esi, Context::SlotOffset(Context::GLOBAL_INDEX))); On 2010/04/21 11:13:27, antonm wrote:
ditto for ContextOperand
Done. http://codereview.chromium.org/1731002/diff/1/3#newcode6571 src/ia32/codegen-ia32.cc:6571: ASSERT(tmp.is_valid()); On 2010/04/21 11:13:27, antonm wrote:
just curious. tmp.reg() below has this assert as well. What is our
common
approach, to put such assert or not?
I can't comment for the whole team, but my preference is to check register allocation results early (especially in inline functions like this one that depend on the state of the current frame). http://codereview.chromium.org/1731002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
