Reviewers: Erik Corry, Description: Fix bug in KeyedLoadIC generic stub where signed instead of unsigned comparison was used.
Please review this at http://codereview.chromium.org/1769005/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/ic-arm.cc A test/mjsunit/regress/regress-685.js Index: test/mjsunit/regress/regress-685.js =================================================================== --- test/mjsunit/regress/regress-685.js (revision 0) +++ test/mjsunit/regress/regress-685.js (revision 0) @@ -0,0 +1,43 @@ +// Copyright 2010 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Regression test for http://code.google.com/p/v8/issues/detail?id=685. +// +// Test that keyed load IC generic stub uses unsigned comparison for +// for the length field of arrays. +// +// The test passes if it does not crash. + +function test() { + var N = 0xFFFFFFFF; + var a = []; + a[N - 1] = 0; + a[N - 2] = 1; + a.reverse(); +} + +test(); Index: src/arm/ic-arm.cc =================================================================== --- src/arm/ic-arm.cc (revision 4482) +++ src/arm/ic-arm.cc (working copy) @@ -710,7 +710,7 @@ // Check that the key (index) is within bounds. __ ldr(r3, FieldMemOperand(r1, Array::kLengthOffset)); __ cmp(r0, Operand(r3)); - __ b(ge, &slow); + __ b(hs, &slow); // Fast case: Do the load. __ add(r3, r1, Operand(FixedArray::kHeaderSize - kHeapObjectTag)); __ ldr(r0, MemOperand(r3, r0, LSL, kPointerSizeLog2)); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
