LGTM
http://codereview.chromium.org/1756013/diff/1/2 File test/mjsunit/regress/regress-crbug-40931.js (right): http://codereview.chromium.org/1756013/diff/1/2#newcode34 test/mjsunit/regress/regress-crbug-40931.js:34: var names = "a,b,c,d".split(/,/); Try doing the split twice with the same arguments. The bug was introduced by caching, so it's a better test the result after caching has happened. http://codereview.chromium.org/1756013/diff/1/2#newcode37 test/mjsunit/regress/regress-crbug-40931.js:37: for(i in names) { You are assuming iteration order, which isn't guaranteed by specification. Instead collect the keys in an array, then sort and join them before comparing. http://codereview.chromium.org/1756013/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
