http://codereview.chromium.org/1735007/diff/15001/16001 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/1735007/diff/15001/16001#newcode5389 src/arm/codegen-arm.cc:5389: __ tst(r0, Operand(kSmiTagMask)); On 2010/04/26 15:07:31, antonm wrote:
On 2010/04/23 14:56:47, Erik Corry wrote: > On 2010/04/23 10:37:41, antonm wrote: > > r0 is an object, no? Should it be r1 and check that key is smi? > > > > And sorry for being pushy but there is BranchOnSmi > > I don't think it works for deferred. Perhaps we should have
BranchOnSmi on
> deferred. > >
You're right, Erik. Let me add one not to sound silly next time :)
Wait, won't __ BranchOnSmi(r1, deferred->entry_label()); do the trick? http://codereview.chromium.org/1735007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
