LGTM
http://codereview.chromium.org/1692015/diff/1/3 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/1692015/diff/1/3#newcode5915 src/x64/codegen-x64.cc:5915: __ SmiToInteger32(left_, left_); If you have a spare register here, you could convert left_ into an integer in that and not have to convert it back afterwards. This is X64 - it should be possible to allocate a register - or can't we because this is deferred code? http://codereview.chromium.org/1692015/diff/1/3#newcode5921 src/x64/codegen-x64.cc:5921: __ AllocateHeapNumber(dst_, left_, &after_alloc_failure); I'll bet I can make a version of AllocateHeapNumber/AllocateInNewSpace that doesn't use any scratch registers (except for kScratchRegister ofcourse). That would save you from push/popping here - if you can't get a scratch register somehow. http://codereview.chromium.org/1692015/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
