Added EmitPush(Operand), EmitPushRoot(Heap::RootLiastIndex) and updated the
code
accordingly.
http://codereview.chromium.org/1732024/diff/1/2
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/1732024/diff/1/2#newcode1566
src/arm/codegen-arm.cc:1566: frame_->EmitPush(cp);
Updated with EmitPush(Operand).
http://codereview.chromium.org/1732024/diff/1/2#newcode1573
src/arm/codegen-arm.cc:1573: {
On 2010/04/29 21:23:18, Erik Corry wrote:
The braces here are not necessary.
Done.
http://codereview.chromium.org/1732024/diff/1/2#newcode1599
src/arm/codegen-arm.cc:1599: Register reg = frame_->GetTOSRegister();
On 2010/04/29 21:23:18, Erik Corry wrote:
We should have an EmitPush(Operand op) as a shorthand for these three.
It would
be almost identical in implementation to EmitPush(MemOperand).
Done.
http://codereview.chromium.org/1732024/diff/1/2#newcode1617
src/arm/codegen-arm.cc:1617: VirtualFrame::SpilledScope
spilled_scope(frame_);
On 2010/04/29 21:23:18, Erik Corry wrote:
No need for this spilled scope really. Just substitute Load for
LoadAndSpill in
the line immediately below.
Done.
http://codereview.chromium.org/1732024/diff/1/2#newcode1624
src/arm/codegen-arm.cc:1624: {
On 2010/04/29 21:23:18, Erik Corry wrote:
No need for these braces.
Done.
http://codereview.chromium.org/1732024/diff/1/2#newcode1645
src/arm/codegen-arm.cc:1645: VirtualFrame::SpilledScope
spilled_scope(frame_);
On 2010/04/29 21:23:18, Erik Corry wrote:
I don't think you need this spilled scope. The LoadAndSpill can be a
Load and
the target.SetValue is able to cope with non-spilled frames. There
are no
JumpTargets or deferred code here that would get confused about
non-spilled
frames. Drop can cope with and take advantage of a non-spilled frame
too.
Done.
http://codereview.chromium.org/1732024/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
