Revision: 4561
Author: [email protected]
Date: Mon May 3 02:53:47 2010
Log: No implicit conversion between a Foo** and a Handle<Foo>.
Review URL: http://codereview.chromium.org/1861001
http://code.google.com/p/v8/source/detail?r=4561
Modified:
/branches/bleeding_edge/src/handles.h
/branches/bleeding_edge/src/x64/assembler-x64.cc
=======================================
--- /branches/bleeding_edge/src/handles.h Mon Apr 19 09:08:26 2010
+++ /branches/bleeding_edge/src/handles.h Mon May 3 02:53:47 2010
@@ -42,7 +42,7 @@
template<class T>
class Handle {
public:
- INLINE(Handle(T** location)) { location_ = location; }
+ INLINE(explicit Handle(T** location)) { location_ = location; }
INLINE(explicit Handle(T* obj));
INLINE(Handle()) : location_(NULL) {}
=======================================
--- /branches/bleeding_edge/src/x64/assembler-x64.cc Wed Apr 28 07:43:51
2010
+++ /branches/bleeding_edge/src/x64/assembler-x64.cc Mon May 3 02:53:47
2010
@@ -116,8 +116,10 @@
CodeDesc desc;
assm.GetCode(&desc);
- Object* code =
- Heap::CreateCode(desc, NULL, Code::ComputeFlags(Code::STUB), NULL);
+ Object* code = Heap::CreateCode(desc,
+ NULL,
+ Code::ComputeFlags(Code::STUB),
+ Handle<Object>());
if (!code->IsCode()) return;
PROFILE(CodeCreateEvent(Logger::BUILTIN_TAG,
Code::cast(code), "CpuFeatures::Probe"));
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
