LGTM
http://codereview.chromium.org/1944001/diff/9001/10006 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/1944001/diff/9001/10006#newcode4400 src/arm/codegen-arm.cc:4400: // Swap elements. Register tmp3 = object; object = no_reg? http://codereview.chromium.org/1944001/diff/9001/10007 File src/arm/codegen-arm.h (right): http://codereview.chromium.org/1944001/diff/9001/10007#newcode882 src/arm/codegen-arm.h:882: // Minor key encoding in 12 bits of three registers (object, address and ... bits of three registers ... -> ... bits. 4 bits for each of the three registers ... http://codereview.chromium.org/1944001/diff/9001/10008 File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/1944001/diff/9001/10008#newcode237 src/arm/macro-assembler-arm.cc:237: Register scratch) { Maybe add an assert for InNewSpace guarded by the --debug-code flag. Relevant on all three platforms. http://codereview.chromium.org/1944001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
