http://codereview.chromium.org/1865001/diff/36001/51001 File src/fixed-dtoa.cc (right):
http://codereview.chromium.org/1865001/diff/36001/51001#newcode244 src/fixed-dtoa.cc:244: // point loccation. location. Again, comment that point is decremented by 3 before we get numbers above 1.0 in fixed point notation, so that we don't overflow. Why not multiply by 5^8, so that you get an int32 worth of integer digits to convert at a time? http://codereview.chromium.org/1865001/diff/36001/51001#newcode286 src/fixed-dtoa.cc:286: if (exponent > 20) return false; Isn't exponent a binary exponent? I thought 20 was a limit on the decimal exponent. Why do we need this (rather low) limit on the binary exponent? http://codereview.chromium.org/1865001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
