Reviewers: Lasse Reichstein,

Description:
Improve static type information in (constant SHL smi) computation.

Please review this at http://codereview.chromium.org/1910002/show

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     src/ia32/codegen-ia32.cc
  M     src/x64/codegen-x64.cc


Index: src/ia32/codegen-ia32.cc
===================================================================
--- src/ia32/codegen-ia32.cc    (revision 4574)
+++ src/ia32/codegen-ia32.cc    (working copy)
@@ -2197,7 +2197,7 @@
                                                    overwrite_mode);
         __ mov(answer.reg(), Immediate(int_value));
         __ sar(ecx, kSmiTagSize);
-        if (!right.type_info().IsSmi()) {
+        if (!right_type_info.IsSmi()) {
           deferred->Branch(carry);
         } else if (FLAG_debug_code) {
           __ AbortIfNotSmi(right.reg());
Index: src/x64/codegen-x64.cc
===================================================================
--- src/x64/codegen-x64.cc      (revision 4574)
+++ src/x64/codegen-x64.cc      (working copy)
@@ -6558,7 +6558,7 @@
                                                    overwrite_mode);
         __ movq(answer.reg(), Immediate(int_value));
         __ SmiToInteger32(rcx, rcx);
-        if (!right.type_info().IsSmi()) {
+        if (!right_type_info.IsSmi()) {
           Condition is_smi = masm_->CheckSmi(right.reg());
           deferred->Branch(NegateCondition(is_smi));
         } else if (FLAG_debug_code) {


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to