Erik, > That's good. Let me know when Kun has integrated the changes I asked for > in > the last code review.
I merged all changes to the bleeding edge and uploaded for review in the case 1881002. -Kun > Den 4. maj 2010 08.32 skrev <[email protected]>: > >> Erik, here's two other older issues that need review: >> - Issue 621008: Inlining of fast path for bitwise XOR, AND, OR binary >> operations. >> - Issue 568029: Add support for ldrd/strd. >> > > I'll take a look at these. > > >> Also as per your final comment on the constant pool work, Kun has merged >> all the changes into the latest v8 bleeding edge and created a new >> issue: >> 1881002 Optimize const pool with movw/movt. >> > > That's good. Let me know when Kun has integrated the changes I asked for > in > the last code review. > > >> >> >> -Subrato. >> >> >> > I'm afraid I didn't see this one when it was posted. If you need a >> review >> > it's >> > a good idea to send mails, and if we forget about them it's a good >> idea >> to >> > send >> > reminders. Sorry about that. >> > >> > I think this change is probably obsoleted by the register allocation >> stuff >> > that >> > has happened since. >> > >> > http://codereview.chromium.org/1340003/show >> > >> >> >> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
