Uploaded patch set 6 with the above recommended changes.
Does this change ensure that the code in objects.cc (string copy I think)
also takes advantage of unaligned accesses?
Yes.
The CAN_USE_UNALIGNED_ACCESSES macro is also used to set
V8_HOST_CAN_READ_UNALIGNED in globals.h, which in turn enables unaligned
read/writes usage for:
(i) CopyChars & CompareChars in utils.h
(ii) CompareRawStringContents in objects.cc
The CopyChars() in (i) are in-turn used to implement String::WriteToFlat()
in
objects.cc
http://codereview.chromium.org/1731013/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
