LGTM
http://codereview.chromium.org/1694011/diff/55001/56002 File include/v8.h (right): http://codereview.chromium.org/1694011/diff/55001/56002#newcode697 include/v8.h:697: static const int kNoLineNumberInfo = 0; Please remove empty line. http://codereview.chromium.org/1694011/diff/55001/56002#newcode704 include/v8.h:704: * A JavaScript stack trace. This will only include JavaScript associated Please revise this comment into soething like this "Representation of a JavaScript stack trace. The information collected is a snapshot of the execution stack and the information remains valid after execution continues." I don't think we should mention stuff about V8's native runtime.js here as embedders should not worry about that. http://codereview.chromium.org/1694011/diff/55001/56002#newcode741 include/v8.h:741: * Grabs the current JavaScript StackTrace. Grabs the current JavaScript StackTrace. -> Grab a snapshot of the the current JavaScript execution stack. http://codereview.chromium.org/1694011/diff/55001/56002#newcode760 include/v8.h:760: * This method will return kNotFound if it is unable to retrieve the line kNotFound -> Message::kNoLineNumberInfo http://codereview.chromium.org/1694011/diff/55001/56002#newcode761 include/v8.h:761: * number, or if LINE_NUMBER was not passed as an option when capturing the LINE_NUMBER -> kLineNumber http://codereview.chromium.org/1694011/diff/55001/56002#newcode769 include/v8.h:769: * This method will return kNotFound if it is unable to retrieve the column kNotFound -> Message::kNoLineNumberInfo http://codereview.chromium.org/1694011/diff/55001/56002#newcode770 include/v8.h:770: * number, or if COLUMN_OFFSET was not passed as an option when capturing the COLUMN_OFFSET -> kColumnOffset http://codereview.chromium.org/1694011/diff/55001/56002#newcode787 include/v8.h:787: * Returns whether or not the associated function was run via a call to was run -> is compiled http://codereview.chromium.org/1694011/diff/55001/56002#newcode793 include/v8.h:793: * Returns whther or not the associated function is being run as a being run -> called http://codereview.chromium.org/1694011/diff/55001/56008 File src/messages.js (right): http://codereview.chromium.org/1694011/diff/55001/56008#newcode205 src/messages.js:205: function GetLineNumber(message) { Please add the constant kNoLineNumberInfo to JavaScript somewhere. http://codereview.chromium.org/1694011/diff/55001/56004 File src/top.cc (right): http://codereview.chromium.org/1694011/diff/55001/56004#newcode399 src/top.cc:399: SetProperty(stackFrame, Factory::LookupAsciiSymbol("column"), You might consider moving the calls to Factory::LookupAsciiSymbol(xxx) to before the loop so there will only be one lookup for each. http://codereview.chromium.org/1694011/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
