Reviewers: Søren Gjesse, Message: One line review
Description: Use Int32Value() instead of ToNumber()->Value() in test-api.cc. This problem was introduced in revision 4597. ToNumber()->Value() used as an int will throw a compile waring on windows since it returns a double. Please review this at http://codereview.chromium.org/2037001/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M test/cctest/test-api.cc Index: test/cctest/test-api.cc =================================================================== --- test/cctest/test-api.cc (revision 4600) +++ test/cctest/test-api.cc (working copy) @@ -9614,7 +9614,7 @@ ASSERT(args.Length() == 1); - int testGroup = args[0]->ToNumber()->Value(); + int testGroup = args[0]->Int32Value(); if (testGroup == kOverviewTest) { v8::Handle<v8::StackTrace> stackTrace = v8::StackTrace::CurrentStackTrace(10, v8::StackTrace::kOverview); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
