Reviewers: William Hesse, Description: Remove unused function in ia32 code generator
Please review this at http://codereview.chromium.org/1996006/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/ia32/codegen-ia32.h M src/ia32/codegen-ia32.cc Index: src/ia32/codegen-ia32.cc =================================================================== --- src/ia32/codegen-ia32.cc (revision 4607) +++ src/ia32/codegen-ia32.cc (working copy) @@ -829,14 +829,6 @@ } -void CodeGenerator::UnloadReference(Reference* ref) { - // Pop a reference from the stack while preserving TOS. - Comment cmnt(masm_, "[ UnloadReference"); - frame_->Nip(ref->size()); - ref->set_unloaded(); -} - - // ECMA-262, section 9.2, page 30: ToBoolean(). Pop the top of stack and // convert it to a boolean in the condition code register or jump to // 'false_target'/'true_target' as appropriate. Index: src/ia32/codegen-ia32.h =================================================================== --- src/ia32/codegen-ia32.h (revision 4607) +++ src/ia32/codegen-ia32.h (working copy) @@ -48,7 +48,7 @@ // A reference is a C++ stack-allocated object that puts a // reference on the virtual frame. The reference may be consumed -// by GetValue, TakeValue, SetValue, and Codegen::UnloadReference. +// by GetValue, TakeValue and SetValue. // When the lifetime (scope) of a valid reference ends, it must have // been consumed, and be in state UNLOADED. class Reference BASE_EMBEDDED { @@ -414,7 +414,6 @@ // The following are used by class Reference. void LoadReference(Reference* ref); - void UnloadReference(Reference* ref); static Operand ContextOperand(Register context, int index) { return Operand(context, Context::SlotOffset(index)); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
