http://codereview.chromium.org/1695007/diff/1003/9003 File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/1695007/diff/1003/9003#newcode4294 src/x64/codegen-x64.cc:4294: STATIC_ASSERT(kSmiTagSize == 1); Definitly a bad idea, and not true. The current[1] smi encoding keeps the value in the top 32 bits of the 64-bit value. [1] And I hope to be able to change that at some point. http://codereview.chromium.org/1695007/diff/1003/9003#newcode4368 src/x64/codegen-x64.cc:4368: __ lea(rbx, Operand(rdx, JSFunctionResultCache::kEntrySize << 1)); This does seem wrong if rdx holds a smi. You need to either convert it to integer, or convert it to a SmiIndex (which amounts to the same thing with the current encoding) before using it as index register. http://codereview.chromium.org/1695007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
