LGTM

http://codereview.chromium.org/2027002/diff/11001/12001
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2027002/diff/11001/12001#newcode3708
src/arm/codegen-arm.cc:3708: //  with (obj) foo(1, 2, 3)  // foo is in
obj
As I understand it the point of this code is to go fast when foo could
be in obj, but in fact it isn't.  So I would prefer "foo may be in obj."
 Note the full stop.

http://codereview.chromium.org/2027002/diff/11001/12001#newcode3713
src/arm/codegen-arm.cc:3713: //    f();  // f could be in extension
object
Full stop.

http://codereview.chromium.org/2027002/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to