LGTM

http://codereview.chromium.org/2047002/diff/21001/19008
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2047002/diff/21001/19008#newcode5913
src/arm/codegen-arm.cc:5913: length + (FixedArray::kHeaderSize /
kPointerSize),
FixedArray::SizeFor(length) and allocation in bytes?

http://codereview.chromium.org/2047002/diff/21001/19009
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/2047002/diff/21001/19009#newcode963
src/arm/macro-assembler-arm.cc:963: add(result, result,
Operand(object_size));
May be add some ASSERTion on object_size alignment?

http://codereview.chromium.org/2047002/diff/21001/19005
File src/arm/macro-assembler-arm.h (right):

http://codereview.chromium.org/2047002/diff/21001/19005#newcode64
src/arm/macro-assembler-arm.h:64: SIZE_IN_WORDS = 1 << 2
Comment about SIZE_IN_WORDS meaning for the sake of uniformity?

http://codereview.chromium.org/2047002/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to