Rico, Lasse, thanks a lot for review.
http://codereview.chromium.org/1960001/diff/1/2 File src/runtime.cc (right): http://codereview.chromium.org/1960001/diff/1/2#newcode7781 src/runtime.cc:7781: Handle<Object> key1 = args.at<Object>(1); On 2010/05/06 09:03:47, Lasse Reichstein wrote:
Consider using CONVERT_ARG_CHECKED for the remaining two arguments
too. It's
(slightly) more efficient than creating a new handle, since it creates
a handle
that is backed by the argument on the stack instead of a HandleScope
entry. Lasse, any chances you meant some other macro: 65 #define CONVERT_ARG_CHECKED(Type, name, index) \ 66 RUNTIME_ASSERT(args[index]->Is##Type()); \ 67 Handle<Type> name = args.at<Type>(index); ? http://codereview.chromium.org/1960001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
