LGTM Thanks for the thorough updating of the tests!
http://codereview.chromium.org/2037008/diff/2001/3001 File src/builtins.cc (right): http://codereview.chromium.org/2037008/diff/2001/3001#newcode333 src/builtins.cc:333: static JSObject* ArrayPrototype(Context* global_context) { Is this function worth it? There seems to be only two calls to it? http://codereview.chromium.org/2037008/diff/2001/3006 File test/mjsunit/array-splice.js (right): http://codereview.chromium.org/2037008/diff/2001/3006#newcode293 test/mjsunit/array-splice.js:293: assertFalse(array.hasOwnProperty(2 << 32 - 1), "array.hasOwnProperty(2 << 31 - 1)"); Long line. http://codereview.chromium.org/2037008/diff/2001/3007 File test/mjsunit/array-unshift.js (right): http://codereview.chromium.org/2037008/diff/2001/3007#newcode118 test/mjsunit/array-unshift.js:118: // Check that unshif with no args has a side-effect of unshif -> unshift http://codereview.chromium.org/2037008/diff/2001/3007#newcode119 test/mjsunit/array-unshift.js:119: // feeling the holes with elements from the prototype feeling -> filling http://codereview.chromium.org/2037008/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
