LGTM from my side.
http://codereview.chromium.org/1989012/diff/9001/10001 File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/1989012/diff/9001/10001#newcode1105 src/arm/full-codegen-arm.cc:1105: __ push(r0); Could you use the stm instruction here for more compact code? http://codereview.chromium.org/1989012/diff/9001/10003 File src/compiler.cc (right): http://codereview.chromium.org/1989012/diff/9001/10003#newcode136 src/compiler.cc:136: #ifdef V8_TARGET_ARCH_IA32 Maybe there is no need for this #ifdef? The FastCodeGen is hidden behind a flag and not enabled by default. We could also consider removing it completely for now (as a separate change). http://codereview.chromium.org/1989012/diff/9001/10004 File src/full-codegen.cc (right): http://codereview.chromium.org/1989012/diff/9001/10004#newcode58 src/full-codegen.cc:58: #ifndef V8_TARGET_ARCH_IA32 Maybe move this #ifndef to the call site of the syntax checker (until the other platforms are completed)? http://codereview.chromium.org/1989012/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
