LGTM
http://codereview.chromium.org/1994019/diff/7001/8001 File src/string.js (right): http://codereview.chromium.org/1994019/diff/7001/8001#newcode406 src/string.js:406: if (start < 0) return; you omit end check, is it fine? is lastCaptureInfo sorted? http://codereview.chromium.org/1994019/diff/7001/8001#newcode449 src/string.js:449: return subject; could reusableResultArray be restored at that point? http://codereview.chromium.org/1994019/diff/7001/8001#newcode470 src/string.js:470: %_CallFunction(receiver, elem, match_start, subject, replace); do we have a cheap way to ensure replace is function here? something like debug mode assert? This separate function is far enough for me to make tracing the check somewhat difficult. http://codereview.chromium.org/1994019/diff/7001/8001#newcode517 src/string.js:517: var s = SubString(subject, index, matchInfo[CAPTURE1]); maybe user endOfMatch here instead of matchInfo[CAPTURE1]? http://codereview.chromium.org/1994019/diff/7001/8001#newcode522 src/string.js:522: var parameters = $Array(m + 2); not for this CL, but I'd be curious to see if push is faster than direct indexing. http://codereview.chromium.org/1994019/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
